-
Notifications
You must be signed in to change notification settings - Fork 790
Concluding v6 deprecation cycle #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request completes the v6 deprecation cycle by removing deprecated functionality that was marked for removal in version 6. The changes eliminate deprecated classes, methods, fields, and warnings that were previously part of the API.
Key changes include:
- Removal of deprecated
Answerclass and various synchronous methods - Cleanup of deprecated configuration fields and their validation logic
- Removal of deprecated function parameters and warning infrastructure
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_paperqa.py | Removes deprecated test cases and import for Answer class |
| src/paperqa/types.py | Removes deprecated Answer class and warning imports |
| src/paperqa/settings.py | Removes deprecated configuration fields and validation logic |
| src/paperqa/docs.py | Removes deprecated synchronous methods and warning infrastructure |
| src/paperqa/agents/search.py | Removes deprecated parameters and validation from get_directory_index |
| src/paperqa/init.py | Removes deprecated imports and warning filters |
| README.md | Updates documentation to reflect new configuration structure |
5ed423f to
7275309
Compare
7275309 to
f196d9d
Compare
f196d9d to
9ec21f5
Compare
9ec21f5 to
3410f13
Compare
jabra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
See PR title